The bytes // they want you

@pnevyk’s words on programming

Checklist: Review as reviewer

This is a checklist for reviews from the perspective of reviewer (see also the submitter part). It’s minimalistic and focuses on the soft side of the topic, not on the technicalities and rigor of the process. The goal is to be applicable in general context, but it’s targetted at code reviews specifically.

Checklist #

Read this before starting a review and then go through it before clicking the “Submit review” button.

QuickExpanded
Resources
  1. The Priority Inversion | The Death of a Thousand Round Trips | Prioritize Your Feedback | Conventional Comments | Review comments prioritization
  2. Using comments to add value | Accept That There Are Different Solutions | Stop Nitpicking in Code Reviews | Three Filters For Feedback | Set the pass threshold
  3. The Guessing Game | Mind the OIR-Rule of Giving Feedback | Giving Guidance | Clear feedback
  4. Ask Questions | Clear feedback | Using comments to add value
  5. Talk About the Code, Not the Coder | Write/review with empathy | Courtesy | Accentuate the positive
  6. Honesty

For code reviewer’s technical checklists, see